Skip to content

Conversation

agaudreault
Copy link
Member

partial cherry-pick of #754 to mitigate argoproj/argo-cd#23226 on 3.0.

This does not fix the codepaths that do not remove the finalizers, but allows new sync to work correctly to remediate the issue.

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner August 22, 2025 21:44
Copy link

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-3.0@89c110b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 40.90% 13 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-3.0     #761   +/-   ##
==============================================
  Coverage               ?   47.30%           
==============================================
  Files                  ?       64           
  Lines                  ?     6557           
  Branches               ?        0           
==============================================
  Hits                   ?     3102           
  Misses                 ?     3198           
  Partials               ?      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agaudreault agaudreault changed the base branch from master to release-3.0 August 22, 2025 21:51
@agaudreault agaudreault changed the title fix(hooks): always remove finalizers fix(hooks): always remove finalizers on create if hook exists Sep 2, 2025
@agaudreault agaudreault merged commit d96c3d5 into argoproj:release-3.0 Sep 5, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants