Skip to content

Conversation

runakash
Copy link
Member

@runakash runakash commented Nov 7, 2022

Issue #, if available: Fixes #36

Description of changes: Add rate limiter to the AWS CloudMap API calls. We are noticing increase throttling for few customers, this will align controller's api limits with Cloudmap's.
Increasing the base delay of the service export reconciler's rate limiter, this will increase the back-off period if AWS CloudMap is having a downtime.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… of the service export reconciler's rate limiter.
@runakash runakash requested a review from astaticvoid November 7, 2022 21:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (3f1bd63) to head (ed3bd01).
Report is 161 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cloudmap/api.go 17.64% 11 Missing and 3 partials ⚠️
...ntrollers/multicluster/serviceexport_controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   71.55%   70.91%   -0.65%     
==========================================
  Files          16       16              
  Lines        1747     1767      +20     
==========================================
+ Hits         1250     1253       +3     
- Misses        411      425      +14     
- Partials       86       89       +3     
Files with missing lines Coverage Δ
...ntrollers/multicluster/serviceexport_controller.go 39.04% <0.00%> (-0.69%) ⬇️
pkg/cloudmap/api.go 75.00% <17.64%> (-5.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1bd63...ed3bd01. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@runakash runakash merged commit 2db7055 into aws:main Nov 7, 2022
@runakash runakash deleted the add-api-rate-limiter branch November 15, 2022 18:59
runakash added a commit to runakash/aws-cloud-map-mcs-controller-for-k8s that referenced this pull request Jun 20, 2025
… of the service export reconciler's rate limiter. (aws#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Cloud Map client-side traffic throttling
3 participants