Allow finish step to update environment name #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API allows for updating the environment name when creating a status: https://docs.github.com/en/rest/deployments/statuses?apiVersion=2022-11-28#create-a-deployment-status
bobheadxi
approved these changes
May 23, 2023
bobheadxi
added a commit
that referenced
this pull request
May 23, 2023
This reverts commit 9bf3b18.
bobheadxi
reviewed
May 23, 2023
| @@ -18,7 +19,7 @@ async function createFinish( | |||
| ) { | |||
| const { | |||
| log, | |||
| coreArgs: { description, logsURL }, | |||
| coreArgs: { description, logsURL, environment }, | |||
| } = context; | |||
There was a problem hiding this comment.
Thanks for the contribution, but this change doesn't seem quite right. This environment is from context, whereas it seems you are trying to parameterize it as an action input?
Either way, both don't align with the createDeploymentStatus which only allows a set of values "production" | "staging" | "qa" so this doesn't build
There was a problem hiding this comment.
I've reverted the changes for now
bobheadxi
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API allows for updating the environment name when creating a status: https://docs.github.com/en/rest/deployments/statuses?apiVersion=2022-11-28#create-a-deployment-status