Correct detection of out of project frames in e2e tests #2275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolve a common flake caused by incorrect detection of out of project frames.
Design
If a
!is present in the stackframe file,symbolicatewas only passing everything after it tois_out_of_project?. But that function expects to receive the whole path to detect out of project frames correctly. This was causing theStack buffer overflowscenario to flake. Sometimes the frame is provided as:and sometimes (the flaky case) it is:
Changeset
I've also fixed a few style errors highlighted by my IDE.
Testing
Covered by a full CI run.