-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ref
parameters, arguments, returns and val
returns
#5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,701
−35
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
9648270
Filling out template with PR 5434
josh11b a0b90c7
Checkpoint progress.
josh11b 7cc4b32
Checkpoint progress.
josh11b bf4930f
Checkpoint progress.
josh11b cc0a1f3
Checkpoint progress.
josh11b eb2ab64
Checkpoint progress.
josh11b a71ba59
Checkpoint progress.
josh11b 018dda5
Checkpoint progress.
josh11b cbacede
Checkpoint progress.
josh11b 2d6a7a3
Checkpoint progress.
josh11b 4a87f20
Checkpoint progress.
josh11b 90d250e
Checkpoint progress.
josh11b 8151bed
Checkpoint progress.
josh11b 7172159
Checkpoint progress.
josh11b 66a6f47
Checkpoint progress.
josh11b 8060cf7
Checkpoint progress.
josh11b 4b1584d
Checkpoint progress.
josh11b c89d46d
Ready for review
josh11b 0894f68
Oops, missed a couple of final touches
josh11b 79d6ddb
Merge remote-tracking branch 'upstream/trunk' into ref
josh11b acec7d9
Apply suggestions from code review
josh11b 626c3ae
Updates inspired by review
josh11b 319f5eb
Fix incorrect statement
josh11b 28d8cc2
Changes in response to review
josh11b 3570dc0
Update proposals/p5434.md
josh11b 3f654fc
Move indexing changes to the relevant design doc
josh11b 2a76c74
Incorporate more feedback
josh11b 2915e39
typo
josh11b cf7d94e
Implement suggestion
josh11b 4075aed
Add small section on completeness
josh11b 3e13632
Title
josh11b 0fdf298
Consider alternative category for `=>`
josh11b b8cd942
Add alternative
josh11b 09c9455
Merge alternatives
josh11b 00b06b0
Improve indexing
josh11b 3abc014
Checkpoint progress.
josh11b 769e122
BindToValue
josh11b 72c79b2
Apply suggestions from code review
josh11b 523022c
Address some feedback
josh11b a90a7af
Update proposals/p5434.md
josh11b 24c736c
Checkpoint progress.
josh11b 2aca8e8
Merge remote-tracking branch 'refs/remotes/origin/ref' into ref
josh11b 0cac941
Checkpoint progress.
josh11b 38f0f90
Checkpoint progress.
josh11b 7e688a3
Checkpoint progress.
josh11b 7787bd0
Checkpoint progress.
josh11b 37b5c84
Checkpoint progress.
josh11b a11e69f
Checkpoint progress.
josh11b c8e37f3
`init`
josh11b eb1df53
Update custom value representation syntax to use `ref` keyword
josh11b 9ec8a85
Add text to hopefully address confusion, as suggested in review
josh11b 50417f4
Apply suggestions from code review
josh11b 08f332b
Checkpoint progress.
josh11b 1f5129a
Checkpoint progress.
josh11b 90d4ec4
Implement suggestions
josh11b d14726d
Implement suggestions
josh11b cfe2a65
Apply suggestions from code review
josh11b 3520180
Add TODO about updating initializing return docs
josh11b 5aa00c7
Fix formatting
josh11b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Commenting here since there's no better place for it)
If I understand correctly, the "Deferred initialization from values and references" section below is basically just saying that the compiler can rewrite
-> Foo
to-> let Foo
if that would be safe and correct (see also discussion here). If so, it would be nice to say so explicitly, and remove or relocate all the verbiage that amounts to explaining the semantics of-> let
. It's fine if that's a TODO, I just want to make sure it doesn't get lost.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this would remove the explanation of the semantics of
-> val Foo
?I also think we don't yet know the exact model we want here in terms of value representation, and so not sure there is anything to really do here yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was unclear. It seems like that section's explanation of the alternate semantics that the compiler is allowed to give to
-> Foo
, is also an explanation of the semantics of-> val Foo
. If so, that material should either be replaced with a cross-reference to the canonical documentation for-> val Foo
, or it should be relocated and rephrased in order to become the canonical documentation for-> val Foo
(leaving behind a cross-reference to the new location).You think it's too soon to even have a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a TODO.