Dry run #125
Merged
Dry run #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psalz
requested changes
Jul 21, 2022
PeterTh
reviewed
Jul 21, 2022
psalz
requested changes
Jul 25, 2022
psalz
reviewed
Jul 25, 2022
psalz
reviewed
Jul 25, 2022
facuMH
force-pushed
the
dry_run
branch
3 times, most recently
from
333c2ef to
56276cf
Compare
psalz
requested changes
Jul 26, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
BlackMark29A
requested changes
Jul 29, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
BlackMark29A
requested changes
Jul 31, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
BlackMark29A
approved these changes
Jul 31, 2022
fknorr
approved these changes
Aug 2, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to able to simulate a run to analyze behavior and how would celerity scale to larger amounts nodes, without necessarily having those nodes.
For this we are not flushing commands unless they are epochs ( and this ones only to the master node).