Experimental support for AdaptiveCpp SSCP flow #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (6dd39f6a6c050e624420039722ed76eb) ❓ No new benchmark data submitted. ❓ |
PeterTh
reviewed
Oct 17, 2024
fknorr
force-pushed
the
acpp-sscp
branch
2 times, most recently
from
f62c4c4 to
f29f56f
Compare
|
Check-perf-impact results: (e884a5b266877a2f8b1f68ea7d0b8bef) ❓ No new benchmark data submitted. ❓ |
Pull Request Test Coverage Report for Build 11438165966Details
💛 - Coveralls |
Single-pass compilation cannot provide __SYCL_DEVICE_ONLY__ detection macro, so we need to guard accessor hydration with __acpp_if_target_host(). This works because AdaptiveCpp does not verify that kernels are actually device copyable. For DPC++ (and anything else) we still need to conditionally remove definitions for accessor copy and move ctors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-pass compilation cannot provide
__SYCL_DEVICE_ONLY__detection macro, so we need to guard accessor hydration with__acpp_if_target_host(). This works because AdaptiveCpp does not verify that kernels are actually device copyable.For DPC++ (and anything else) we still need to conditionally remove definitions for accessor copy and move ctors.
This now works on my machine ™️, but there is no CI integration yet.