Fix: Update runtime last-epoch-reached before resuming from sync #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This race was likely inconsequential for the runtime correctness, but was observable through the unit test "reaching an epoch will prune all nodes of the preceding task graph".
|
Check-perf-impact results: (120b801fc25bb311186a33753cc215e6) ❓ No new benchmark data submitted. ❓ |
psalz
approved these changes
Nov 15, 2024
Pull Request Test Coverage Report for Build 11854698512Details
💛 - Coveralls |
PeterTh
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition spuriously observed in unit tests after #299.
The unit test assumes that the runtime knows about the epoch being reached as soon as
syncreturns, but we signalled the epoch-promise before updating the reached epoch. This PR flips the signalling order so that the future establishes a proper happens-before-relationship aroundsyncandlast_epoch_reached.