Skip to content

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Dec 9, 2024

Since celerity/SimSYCL#14 is now merged, we don't need explicit threading workarounds in the backend anymore.

@fknorr fknorr added this to the 0.7.0 milestone Dec 9, 2024
@fknorr fknorr requested a review from PeterTh December 9, 2024 14:50
@fknorr fknorr self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@fknorr fknorr force-pushed the thread-safe-simsycl branch from a0440f8 to 539b74b Compare December 9, 2024 14:57
@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12787716791

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 95.128%

Files with Coverage Reduction New Missed Lines %
src/backend/sycl_backend.cc 2 89.86%
Totals Coverage Status
Change from base Build 12787655228: 0.07%
Covered Lines: 7085
Relevant Lines: 7186

💛 - Coveralls

@fknorr fknorr force-pushed the thread-safe-simsycl branch from 539b74b to 9184c35 Compare January 15, 2025 11:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@fknorr fknorr force-pushed the thread-safe-simsycl branch from 9184c35 to 3fd21c8 Compare January 15, 2025 11:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@fknorr fknorr force-pushed the thread-safe-simsycl branch from 3fd21c8 to eeff793 Compare January 15, 2025 11:51
Copy link

Check-perf-impact results: (c8fb992b35322012b54e351345fdf71a)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@fknorr fknorr merged commit 2085917 into master Jan 15, 2025
17 checks passed
@fknorr fknorr deleted the thread-safe-simsycl branch January 15, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants