Use Process.exec in shards run
#686
Conversation
|
Just noting that tests are failing |
|
We're stopping execution of the current program with For now I'm adding a patch to explicitly close the log backend, which flushes all pending message. But this seems like a general problem that should be addressed in the Crystal repo. |
|
The failure on Windows is due to crystal-lang/crystal#14422 |
| else | ||
| raise Error.new("Error target #{name} was not found in #{SPEC_FILENAME}") | ||
| end | ||
| exit status.exit_code |
There was a problem hiding this comment.
Wouldn't this continue to raise for STATUS_BREAKPOINT because it is an abnormal exit?
There was a problem hiding this comment.
Oh, yes 🙈 I've been responsible for the last Process::Status API revamp, but still manage to mistake it.
Maybe the confusing part is that #exit_code? returns nil for abnormal exits, which makes sense on Unix (abnormal states are not exit codes), but less so on Windows where they indeed are exit codes. Maybe that's not right...? 🤔
Or we should just use #system_exit_status here... On Windows it fits exactly what we need.
Resolves #685