Add index for generated configurations #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This index allows to identify automatically generated configurations without the need of a naming pattern.
This was
linked to
issues
Nov 15, 2023
Refactor the interface for the configuration management and use it for more configuration managers.
nico-loeber
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This index allows to identify automatically generated configurations without the need of a naming pattern.
This adresses the problem of unnecessarily overwritten configurations and the need of the "DDEV" naming for generated configurations.
The pull request includes the migration of the PHP server configuration management to the new configuration management index.
The Problem/Issue/Bug:
The ddev plugin references generated by configurations by their name "DDEV" this does not allow the name to change based on settings, as the relation would go lost. This is why the php server configuration could not be named by the fqdn till now.
How this PR Solves the Problem:
This PR is changing the name of the generated php server configuration to the fqdn of the ddev project. This is made possible by the configuration management index.
Manual Testing Instructions:
Related Issue Link(s):