Skip to content

Conversation

AkibaAT
Copy link
Collaborator

@AkibaAT AkibaAT commented Aug 18, 2024

The Problem/Issue/Bug:

Resolves issue #296

How this PR Solves the Problem:

Rework the status bar widget implementation to extend EditorBasedStatusBarPopup and StatusBarEditorBasedWidgetFactory respectively instead & remove code handled in the parent class
Use same static ID for the widget in DdevStatusBarWidgetImpl and plugin.xml

Manual Testing Instructions:

  • ./gradlew build
  • Install resulting build/distributions/ddev-intellij-plugin-0.0.1-dev.zip
  • Toggling visibility of the ddev widget should work identical to all first-party widgets and cause no exceptions
  • To test if the tutorial popup is still appearing properly, a tutorial reset might be required. This can be done by removing the got.it.tooltip.ddev entries from options/other.xml within the global IDE directory and restarting the program
    e.g. ~/.config/JetBrains/PhpStorm2024.2/options/other.xml for PhpStorm 2024.2 on Linux

@AkibaAT AkibaAT changed the title Fix visibility change in taskbar Fix visibility change in statusbar Aug 18, 2024
@AkibaAT AkibaAT mentioned this pull request Aug 18, 2024
2 tasks
@AkibaAT
Copy link
Collaborator Author

AkibaAT commented Aug 18, 2024

Updated commit with regression fix, the widget wasn't hidden on non-ddev projects.

@nico-loeber nico-loeber added the bug Something isn't working label Aug 19, 2024
@nico-loeber
Copy link
Collaborator

Thanks for your great work @AkibaAT!
As you did some more changes on this pull request, I will take a closer look and some manual testing.

@AkibaAT
Copy link
Collaborator Author

AkibaAT commented Aug 19, 2024

Thanks for your great work @AkibaAT! As you did some more changes on this pull request, I will take a closer look and some manual testing.

Sure thing!

One small side-effect I know about is that this version no longer prevents clicking on the the widget when DDEV is not in the running state. Instead it displays "Nothing here". Personally I didn't think that was worth re-adding the click handler again over, but I can certainly take another look if that's an issue.

@nico-loeber nico-loeber linked an issue Aug 19, 2024 that may be closed by this pull request
2 tasks
@nico-loeber nico-loeber self-assigned this Aug 19, 2024
@nico-loeber nico-loeber merged commit 34188cb into ddev:main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDEV icon doesn't appear in the PHPStrom status bar
2 participants