feat(ext/process): add collector utilities to ChildProcess.stdout & ChildProcess.stderr
#30552
+125
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Aug 28, 2025
| * Reads the stream to completion. It returns a promise that resolves with | ||
| * the result of parsing the body text as JSON. | ||
| */ | ||
| json(): Promise<any>; |
There was a problem hiding this comment.
it should be any, as that is what Response has, and when ReadableStream gets these utilities directly on it, we would get a conflict on this
0f-0b
reviewed
Aug 28, 2025
bartlomieju
approved these changes
Sep 1, 2025
dsherret
reviewed
Sep 2, 2025
| json(): Promise<any>; | ||
| /** | ||
| * Reads the stream to completion. It returns a promise that resolves with | ||
| * a `USVString` (text). |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
SubprocessReadableStreaminterface that are usedfor
ChildProcess.stdoutandChildProcess.stderr. It's an extension toa regular
ReadableStreamthat provides convenience methods to collectthe output and parse it with
.bytes(),.arrayBuffer(),.text()and.json()helper methods (similarly to the ones available on
Response).Closes #30323