Skip to content

New iPod touch (7th generation) and correct name of others #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2019
Merged

New iPod touch (7th generation) and correct name of others #189

merged 5 commits into from
Jun 3, 2019

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented May 30, 2019 •
edited
Loading

New features

  • Add support for new iPod touch (7th generation).

Changes

  • Rename iPod Touch 5 and 6 to iPod touch (5th generation) and iPod touch (6th generation) which is the proper naming.

@Zandor300 Zandor300 requested a review from denisenepraunig May 30, 2019 22:19
@devicekit-danger-bot
Copy link

devicekit-danger-bot commented May 31, 2019 •
edited
Loading

4 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L625 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L627 - TODOs should be resolved (Longterm we need a better solu…).
⚠️ Source/Device.generated.swift#L1200 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 625 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1200 Prefer empty collection over optional collection.
Device.generated.swift 627 TODOs should be resolved (Longterm we need a better solu...).

Generated by 🚫 Danger

@denisenepraunig
Copy link
Collaborator

Thank you for your effort 👍.

denisenepraunig
denisenepraunig approved these changes Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@denisenepraunig denisenepraunig merged commit 1b473ef into master Jun 3, 2019
@Zandor300 Zandor300 deleted the new-ipod-touch branch June 3, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisenepraunig denisenepraunig denisenepraunig approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zandor300 @devicekit-danger-bot @denisenepraunig