Skip to content

Conversation

jophals
Copy link

@jophals jophals commented Mar 26, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

There needs to be a loading indicating after uploading a file
Ticket

Are there any other pull requests that this one depends on?

No

Anything else the reviewer needs to know?

No

@jophals jophals requested a review from jdamerow March 26, 2025 19:06
@jophals jophals self-assigned this Mar 26, 2025
@diging-jenkins
Copy link

Can one of the admins verify this patch?

@jdamerow
Copy link
Member

Make it so, Jenkins.

@diging-jenkins
Copy link

Jenkins successfully deployed Citesphere to be reviewed!

@jdamerow
Copy link
Member

This is not fixed yet.

  • I select a file.
  • I click upload.
  • it takes a few seconds.
  • then the upload indicator is shown.
  • but what should happen is that the indicator is shown as soon as I click "Upload"

@jdamerow jdamerow closed this Apr 25, 2025
clicking upload button; also improved the layout and spacing
@jophals jophals reopened this May 28, 2025
@diging-jenkins
Copy link

Jenkins successfully deployed Citesphere to be reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants