MSSQL: Detect TableNotFoundException from generic DatabaseObjectNotFoundException

[GromNaN]

Q	A
Type	bug
Fixed issues	fix symfony/symfony#61579

Summary

The error code 15151 is generic, but we can detect the type of object from the message; and throw a TableNotFoundException when the error is for a missing table.

[morozov]

@GromNaN thanks for the patch. It would be good to add an integration test that covers the issue and ensures that the behavior is consistent across all supported platforms.

[GromNaN]

@morozov I agree, I'll try.

[derrabus]

Parsing error messages is really fragile. And IIRC, SQL Server might even emit localized error messages when running on a non-English Windows system. In the context of the issue you're attempting to solve, I wonder if it wouldn't be the more robust solution to catch the DatabaseObjectNotFoundException instead.

[GromNaN]

In the context of the issue you're attempting to solve, I wonder if it wouldn't be the more robust solution to catch the DatabaseObjectNotFoundException instead.

This was done in symfony/symfony#61583, and that fixed the issue.

The goal is to prevent someone else from thinking they can catch a TableNotFoundException when DBAL returns a generic DatabaseObjectNotFoundException on SQL Server.

Parsing error messages is really fragile. And IIRC, SQL Server might even emit localized error messages when running on a non-English Windows system.

Indeed, there are Local Language Versions in SQL Server and we don't want to parse the message in every possible language. Having the correct exception class thrown only when the server is in English is worse than the current situation where the generic class is always thrown.

[derrabus]

In the context of the issue you're attempting to solve, I wonder if it wouldn't be the more robust solution to catch the DatabaseObjectNotFoundException instead.

This was done in symfony/symfony#61583, and that fixed the issue.

👍🏻

The goal is to prevent someone else from thinking they can catch a TableNotFoundException when DBAL returns a generic DatabaseObjectNotFoundException on SQL Server.

Yeah, I realize that this is a pitfall. We should probably document this as a known limitation. Don't know what's the best place for that though.

Parsing error messages is really fragile. And IIRC, SQL Server might even emit localized error messages when running on a non-English Windows system.

Indeed, there are Local Language Versions in SQL Server and we don't want to parse the message in every possible language. Having the correct exception class thrown only when the server is in English is worse than the current situation where the generic class is always thrown.

Exactly. So, let's close the PR?

[GromNaN]

Closing as this does not improve the situation.