Update EIP-4762: don't charge gas in syscalls #10202
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
3 tasks
lu-pinto
reviewed
Aug 25, 2025
| @@ -52,7 +52,7 @@ process this access event: | |||
| (address, 0, BASIC_DATA_LEAF_KEY) | |||
| ``` | |||
|
|
|||
| Note: a non-value-bearing `SELFDESTRUCT`, `*CALL` or `CALLCODE`, targeting a precompile or a system contract, will not cause the `BASIC_DATA_LEAF_KEY` to be added to the witness. | |||
| Note: a non-value-bearing `SELFDESTRUCT`, `*CALL` or `CALLCODE`, targeting a precompile, will not cause the `BASIC_DATA_LEAF_KEY` to be added to the witness. Similarly, system calls will not add the basic data leaf to the witness. | |||
There was a problem hiding this comment.
Similarly, system calls will not add the basic data leaf to the witness.
I think this should be moved as a point 5, instead. it doesn't make sense for it to be a note.
lu-pinto
reviewed
Aug 25, 2025
| @@ -68,7 +68,7 @@ When calling `EXTCODEHASH`, process the access event: | |||
| (address, 0, CODEHASH_LEAF_KEY) | |||
| ``` | |||
|
|
|||
| Note that precompiles and system contracts are excluded, as their hashes are known to the client. | |||
| Note that precompiles are excluded, as their hashes are known to the client. | |||
There was a problem hiding this comment.
I think this was removed incorrectly? code hashes are indeed known to clients as the contract is immutable after deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of a discussion with Felix during the Stateless Implementer's Call #38: we decided to simplify the rules by saying that any access occurring during a syscall will not add anything to the witness.