trie{,/utils,/bintrie}: add eip7864 binary trees and run its tests #32365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
reviewed
Aug 8, 2025
trie/binary.go
Outdated
| NodeResolverFn func([]byte, common.Hash) ([]byte, error) | ||
| ) | ||
|
|
||
| type BinaryNode interface { |
There was a problem hiding this comment.
It would've been nice if we didn't have a node interface. It makes reasoning about and optimizing for
allocations much harder imo.
gballet
commented
Aug 8, 2025
gballet
commented
Aug 8, 2025
gballet
commented
Aug 8, 2025
gballet
changed the title
gballet
changed the title
gballet
commented
Aug 15, 2025
gballet
commented
Aug 15, 2025
gballet
commented
Aug 15, 2025
gballet
commented
Aug 15, 2025
gballet
commented
Aug 15, 2025
gballet
commented
Aug 15, 2025
| // This will cover HashedNode but that should be fine since the | ||
| // root node should always be resolved. | ||
| return nil, errInvalidRootType | ||
| } |
There was a problem hiding this comment.
could be simpler without the switch, just call the interface method
There was a problem hiding this comment.
actually I just double-checked and GetValueAtStem isn't an interface method.
gballet
commented
Aug 25, 2025
gballet
force-pushed
the
add-binary-tree-tests
branch
from
295fd38 to
1fe759c
Compare
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
…rage (#547) * refactor package * add tests
- Add binary trie implementation in trie/bintrie package - Implement InternalNode, StemNode, Empty, and HashedNode types - Add comprehensive test coverage for binary trie operations - Switch from blake3 to sha256 hashing for compatibility - Add iterator functionality for binary trie traversal - Update PrevalueTracer interface to support binary operations - Include proper error handling and edge case coverage Co-authored-by: Guillaume Ballet <gballet@gmail.com>
gballet
force-pushed
the
add-binary-tree-tests
branch
from
1fe759c to
c5db47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the binary tree as specified in eip-7864. This will gradually replace verkle trees in the codebase. This is only running the tests and will not be executed in production, but will help me rebase some of my work, so that it doesn't bitrot as much.