Skip to content

fix: zones example in data schema #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop-v1.2
Choose a base branch
from
Open

fix: zones example in data schema #204

wants to merge 1 commit into from

Conversation

JaeAeich
Copy link

fixes - #203

uniqueg
uniqueg approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaeAeich
Copy link
Author

Hey, why is the CI failing? I have validated it using openapi lint, lemme know if I missed something and Ill fix it :)!

@uniqueg
Copy link
Contributor

uniqueg commented Jul 23, 2024

Not your fault, I think, @JaeAeich. @kellrott or @vsmalladi: Can you please have a look? 🙏

lvarin
lvarin approved these changes Aug 20, 2024
View reviewed changes
Copy link

@lvarin lvarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uniqueg uniqueg requested review from kellrott and vsmalladi August 20, 2024 12:50
@uniqueg uniqueg mentioned this pull request Aug 21, 2024
Open
@vsmalladi vsmalladi added this to the 1.2 milestone Jan 23, 2025
@vsmalladi vsmalladi changed the base branch from develop to develop-v1.2 March 5, 2025 16:21
@vsmalladi
Copy link
Contributor

Moved this to to a v1.2 branch.

@vsmalladi
Copy link
Contributor

@JaeAeich can you rebase to v1.2 and try again. Also should this be an array?

@uniqueg
Copy link
Contributor

uniqueg commented Mar 5, 2025

@vsmalladi: Indeed zones is an array (of strings) property according to the specs, as @JaeAeich described in #203. Hence the fix of the example, which is not an array.

Array examples in OpenAPI are described here: https://swagger.io/docs/specification/v3_0/adding-examples/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsmalladi vsmalladi vsmalladi approved these changes

@uniqueg uniqueg uniqueg approved these changes

@kellrott kellrott Awaiting requested review from kellrott

+1 more reviewer

@lvarin lvarin lvarin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@JaeAeich @uniqueg @vsmalladi @lvarin