-
-
Notifications
You must be signed in to change notification settings - Fork 361
ref: Convert SentrySdkInfo to Swift #5481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5481 +/- ##
=============================================
- Coverage 86.760% 86.756% -0.005%
=============================================
Files 424 424
Lines 36723 36727 +4
Branches 17365 17356 -9
=============================================
+ Hits 31861 31863 +2
- Misses 4815 4819 +4
+ Partials 47 45 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
cc02c0d | 1234.69 ms | 1247.15 ms | 12.46 ms |
7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
4d264fa | 1223.48 ms | 1246.91 ms | 23.44 ms |
409a607 | 1229.57 ms | 1251.45 ms | 21.88 ms |
80a5166 | 1224.49 ms | 1251.29 ms | 26.80 ms |
029a804 | 1219.65 ms | 1241.96 ms | 22.30 ms |
04ff3ec | 1220.71 ms | 1253.86 ms | 33.15 ms |
aadbffe | 1228.73 ms | 1251.59 ms | 22.86 ms |
73c9712 | 1238.57 ms | 1260.38 ms | 21.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
cc02c0d | 23.75 KiB | 912.37 KiB | 888.62 KiB |
7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
4d264fa | 23.74 KiB | 874.07 KiB | 850.33 KiB |
409a607 | 23.74 KiB | 874.08 KiB | 850.33 KiB |
80a5166 | 23.75 KiB | 904.53 KiB | 880.78 KiB |
029a804 | 23.75 KiB | 928.11 KiB | 904.36 KiB |
04ff3ec | 23.75 KiB | 880.26 KiB | 856.52 KiB |
aadbffe | 23.75 KiB | 912.77 KiB | 889.02 KiB |
73c9712 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
Previous results on branch: convertSentrySdkInfo
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ab9fe41 | 1202.86 ms | 1256.56 ms | 53.71 ms |
1796542 | 1232.46 ms | 1257.69 ms | 25.24 ms |
87a7915 | 1227.19 ms | 1250.33 ms | 23.14 ms |
e2ca600 | 1225.83 ms | 1248.22 ms | 22.39 ms |
2106b14 | 1240.76 ms | 1263.91 ms | 23.16 ms |
c7ba9de | 1233.92 ms | 1249.49 ms | 15.57 ms |
e48f485 | 1211.18 ms | 1233.71 ms | 22.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ab9fe41 | 23.75 KiB | 857.88 KiB | 834.13 KiB |
1796542 | 23.75 KiB | 930.68 KiB | 906.94 KiB |
87a7915 | 23.75 KiB | 930.68 KiB | 906.94 KiB |
e2ca600 | 23.75 KiB | 930.68 KiB | 906.93 KiB |
2106b14 | 23.75 KiB | 927.79 KiB | 904.04 KiB |
c7ba9de | 23.75 KiB | 930.68 KiB | 906.93 KiB |
e48f485 | 23.75 KiB | 857.68 KiB | 833.93 KiB |
30e5a2c
to
443be4f
Compare
18a5ec2
to
579b1e8
Compare
4529ba2
to
e7c9fb6
Compare
e7c9fb6
to
a8889ea
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left two minor comments
@@ -0,0 +1,69 @@ | |||
import XCTest | |||
|
|||
func compareEnvelopes(_ expectedEnvelope: Data?, _ actualEnvelope: Data?, message: String) throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l
: Could be added as an extension of XCTest so it's limited in scope
import Foundation | ||
|
||
extension Data { | ||
func backwardCompatibleSplit(separator: Data) -> [Data] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: Please add documentation and inline-comments to this method so we know the purpose of it, and also know at which point in time we can get rid of the backwards compatilibity
Convert this file to Swift
#skip-changelog