Skip to content

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Aug 23, 2025

I'd like to get rid of this noisy warning:

gems/sentry-rails-5.26.0/lib/sentry/rails/background_worker.rb:5: warning: method redefined; discarding old _perform
gems/sentry-ruby-5.26.0/lib/sentry/background_worker.rb:74: warning: previous definition of _perform was here

#skip-changelog

@viralpraxis viralpraxis force-pushed the silence-perform-method-redefinition-warning branch 2 times, most recently from ba80754 to fdd2a62 Compare August 23, 2025 21:11
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We definitely do not want to have such warnings :) I left one comment.

@viralpraxis viralpraxis force-pushed the silence-perform-method-redefinition-warning branch from fdd2a62 to 2eb43a5 Compare September 2, 2025 15:31
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.32%. Comparing base (337a4ca) to head (e8103e4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   97.44%   97.32%   -0.12%     
==========================================
  Files         136      144       +8     
  Lines        5317     5647     +330     
==========================================
+ Hits         5181     5496     +315     
- Misses        136      151      +15     
Components Coverage Δ
sentry-ruby 97.77% <ø> (+<0.01%) ⬆️
sentry-rails 95.72% <100.00%> (-0.39%) ⬇️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/background_worker.rb 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@viralpraxis viralpraxis force-pushed the silence-perform-method-redefinition-warning branch 5 times, most recently from b8b1cf3 to f04d006 Compare September 2, 2025 17:39
@viralpraxis viralpraxis requested a review from solnic September 3, 2025 19:32
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small adjustment needed 🙏🏻

I'd like to get rid of this noisy warning:

```shell
sentry-rails-5.26.0/lib/sentry/rails/background_worker.rb:5: warning: method redefined; discarding old _perform
sentry-ruby-5.26.0/lib/sentry/background_worker.rb:74: warning: previous definition of _perform was here
```

#skip-changelog

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Sun Aug 24 01:04:29 2025 +0400
#
# On branch silence-perform-method-redefinition-warning
# Changes to be committed:
#	modified:   lib/sentry/rails/background_worker.rb
#
@viralpraxis viralpraxis force-pushed the silence-perform-method-redefinition-warning branch from f04d006 to e8103e4 Compare September 4, 2025 11:04
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇🏻

@solnic solnic merged commit b8bf855 into getsentry:master Sep 4, 2025
138 checks passed
@viralpraxis viralpraxis deleted the silence-perform-method-redefinition-warning branch September 4, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants