-
-
Notifications
You must be signed in to change notification settings - Fork 515
Silence _perform
method redefinition warning
#2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence _perform
method redefinition warning
#2682
Conversation
ba80754
to
fdd2a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! We definitely do not want to have such warnings :) I left one comment.
fdd2a62
to
2eb43a5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2682 +/- ##
==========================================
- Coverage 97.44% 97.32% -0.12%
==========================================
Files 136 144 +8
Lines 5317 5647 +330
==========================================
+ Hits 5181 5496 +315
- Misses 136 151 +15
🚀 New features to boost your workflow:
|
b8b1cf3
to
f04d006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small adjustment needed 🙏🏻
I'd like to get rid of this noisy warning: ```shell sentry-rails-5.26.0/lib/sentry/rails/background_worker.rb:5: warning: method redefined; discarding old _perform sentry-ruby-5.26.0/lib/sentry/background_worker.rb:74: warning: previous definition of _perform was here ``` #skip-changelog # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Sun Aug 24 01:04:29 2025 +0400 # # On branch silence-perform-method-redefinition-warning # Changes to be committed: # modified: lib/sentry/rails/background_worker.rb #
f04d006
to
e8103e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙇🏻
I'd like to get rid of this noisy warning:
#skip-changelog