Skip to content

Conversation

vjeeva
Copy link

@vjeeva vjeeva commented Aug 7, 2025

Summary

Brief description of the changes in this PR.

Type of Change

  • Bug fix
  • New feature
  • Performance improvement
  • Documentation/Tests

Objective

The MCP Server Docker-Compose example .env file just missed one important Azure env variable. It was not clear from the documentation that the client would default to using api.openai.com even when the AZURE_OPENAI_ENDPOINT is set.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Breaking Changes

  • This PR contains breaking changes

If this is a breaking change, describe:

  • What functionality is affected
  • Migration path for existing users

Checklist

  • Code follows project style guidelines (make lint passes)
  • Self-review completed
  • Documentation updated where necessary
  • No secrets or sensitive information committed

Related Issues

Closes #[issue number]


Important

Update mcp_server/.env.example to clarify Azure OpenAI embedding endpoint configuration.

  • Documentation:
    • Update mcp_server/.env.example to include AZURE_OPENAI_EMBEDDING_ENDPOINT.
    • Clarify that AZURE_OPENAI_EMBEDDING_ENDPOINT must be set to avoid defaulting to api.openai.com.

This description was created by Ellipsis for b2fd2b5. You can customize this summary. It will automatically update as commits are pushed.

doc: mcp server env update - Azure OpenAI embedding endpoint
@danielchalef
Copy link
Member

danielchalef commented Aug 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@vjeeva
Copy link
Author

vjeeva commented Aug 7, 2025

I have read the CLA Document and I hereby sign the CLA

danielchalef added a commit that referenced this pull request Aug 7, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b2fd2b5 in 1 minute and 14 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. mcp_server/.env.example:33
  • Draft comment:
    The new Azure OpenAI Embedding docs are helpful. Consider rephrasing the note for improved clarity—for example: 'Ensure AZURE_OPENAI_EMBEDDING_ENDPOINT is set to override the default api.openai.com when using a custom AZURE_OPENAI_ENDPOINT.' Also, adding a comma after 'AZURE_OPENAI_ENDPOINT' could improve readability.
  • Reason this comment was not posted:
    Confidence changes required: 66% <= threshold 80% None
2. mcp_server/.env.example:40
  • Draft comment:
    The duplicate '# AZURE_OPENAI_USE_MANAGED_IDENTITY=false' line has been removed. Confirm that having this variable appear only once meets all configuration needs.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 80% <= threshold 80% The comment points out a potential issue with a configuration variable being removed. It asks for confirmation that the removal meets all configuration needs, which is a valid concern. However, it does not directly ask the author to confirm their intention, but rather to ensure that the configuration is correct. This aligns with the rules for making code suggestions and ensuring correctness.

Workflow ID: wflow_04Sn8LdW3ZkA76FX

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

danielchalef added a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants