Added 'check for updates' button #54
Conversation
|
I'd love to see an integration with the GitHub API as well, we can grab the latest release tag using: That way we can show a nice dialog message in case the user is up-to-date. |
|
Thanks for pointing me in the right direction, my latest commit contains a call to the GitHub API and showing a dialog box, as seen below.
As you can see, I haven't been able to change the icon in the dialog because i'm not sure what image to use and the dialog does not display at all when I add Another thing I'm not really happy about is mediaPlayer.js r.150. I would like to use the As for the version comparison, I've kept it as simple as possible. It just compares the tag from GitHub and the tag inside package.json and if they are equal, the app is up-to-date. Can you let me know what you think? Thanks :) |
| var remote = window.require('remote') | ||
| var Menu = remote.require('menu') | ||
| var MenuItem = remote.require('menu-item') | ||
| var pjson = remote.require('./package.json') |
There was a problem hiding this comment.
EDIT: Nevermind, my bad. :)
👍
|
No problem, if there is anything else please let me know 👍 |
| var tag = response.tag_name.replace(/v/g, '') | ||
|
|
||
| if(pjson.version == tag) { | ||
| return Promise.resolve('Cumulus is currently up-to-date with the most recent version.') |
There was a problem hiding this comment.
I would shorten it to 'Cumulus is currently up-to-date.'.
|
Sorry for the delay, I finally had some time to clean up the last bits today.
|
|
LGTM! 👍 |
Added a 'check for updates' button that links to the latest release page of Cumulus on GitHub.
Not the full auto-update feature issue #39 asks for, but it's a start which I think is useful.