feat(tools/cloud-sql-mysql-list-tables)!: Add new tool for cloud-sql-mysql #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
docs/en/resources/tools/cloudsqlmysql/cloud-sql-mysql-list-tables.md
Outdated
Show resolved
Hide resolved
Myst9
force-pushed
the
cloudsql-mysql-custom-tool
branch
from
51ddd85 to
eba2bf7
Compare
| } | ||
|
|
||
| func (t Tool) RequiresClientAuthorization() bool { | ||
| return false |
There was a problem hiding this comment.
In other pull requests as well is this method required if it is always false
There was a problem hiding this comment.
Yes it is throwing an error if this method is not implemented
Yuan325
changed the title
Yuan325
changed the title
averikitsch
reviewed
Sep 3, 2025
| type: docs | ||
| weight: 1 | ||
| description: > | ||
| Tools that work with CloudSQL MySQL Sources. |
There was a problem hiding this comment.
Cloud SQL should be 2 words. Please update everywhere
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| title: "CloudSQLMySQL" | |||
There was a problem hiding this comment.
Please use the full name Cloud SQL for MySQL
averikitsch
requested changes
Sep 3, 2025
| The `cloud-sql-mysql-list-tables` tool retrieves schema information for all or specified tables in a CloudSQL for MySQL database. | ||
| It is compatible with [cloud-sql-mysql](../../sources/cloud-sql-mysql.md) source. | ||
|
|
||
| `cloud-sql-mysql-list-tables` lists detailed schema information (object type, columns, constraints, indexes, triggers, owner, comment) as JSON for user-created tables (ordinary or partitioned). Filters by a comma-separated list of names. If names are omitted, it lists all tables in user schemas. The output format can be set to `simple` which will return only the table names or `detailed` which is the default. |
There was a problem hiding this comment.
This is nice, but we may want to standardize on a "## Parameters" section
| } | ||
|
|
||
| // validate compatible sources are still compatible | ||
| var _ compatibleSource = &cloudsqlmysql.Source{} |
There was a problem hiding this comment.
This should be compatible with generic mySql as well
|
This should not be labeled as a breaking change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new custom tool kind
cloud-sql-mysql-list-tablesthat allows users to list tables within a Cloud SQL for MySQL database.Example Configuration
Example Request
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change