Skip to content

Style theater #179

@bshi

Description

@bshi

This repository is set up to "Squash Merge" and has a "Conventional Commit" presubmit check to enforce a style of commit message.

But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.

https://lore.kernel.org/lkml/CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com/

This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. Or we should disable the conventional commits presubmit because it's not actually enforcing anything.

Metadata

Metadata

Assignees

No one assigned

    Labels

    triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions