k6/browser: allow Invalid UTF-8 as recommended by cdproto author #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed as a thing that is needed in #4785. This is basically what easyjson was doing before. Due to some internal package structure I opted for a little copying over a little dependency. Mostly as the common package tests depend on tests/ws.
mstoykov
requested review from
oleiade and
codebien
and removed request for
a team
joanlopez
previously approved these changes
May 20, 2025
codebien
reviewed
May 20, 2025
| //nolint:gochecknoglobals | ||
| var defaultJSONV2Options = jsonv2.JoinOptions( | ||
| jsonv2.DefaultOptionsV2(), | ||
| jsontext.AllowInvalidUTF8(true), |
There was a problem hiding this comment.
Can you add a comment on it regarding why so we don't have to blame the git history, please? 🙏
codebien
approved these changes
May 20, 2025
joanlopez
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Configure the jsonv2 experimental marshal/unmarshal to work with invalid utf-8
This was missed as a thing that is needed in #4785.
This is basically what easyjson was doing before.
Due to some internal package structure I opted for a little copying over a little dependency. Mostly as the common package tests depend on tests/ws.
Why?
Apparently it is not uncommon to get invalid utf-8 from chromium and we need to not crash on it.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)