Skip to content

Conversation

mstoykov
Copy link
Contributor

What?

This is backporting #5057 to 1.2.x

Why?

So we can release a 1.2.2 with this fixed.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

This happened due to auto extension resolution wrongly guessing that
`cloud` here means it needs to analyze a script. But it doesn't, and
consequently panics.

Fixes #5055
@mstoykov mstoykov added this to the v1.2.2 milestone Aug 19, 2025
@mstoykov mstoykov requested a review from a team as a code owner August 19, 2025 08:25
@mstoykov mstoykov requested review from oleiade and ankur22 and removed request for a team August 19, 2025 08:25
@mstoykov mstoykov changed the title Backport fix: do not panic on k6 login cloud Backport: fix: do not panic on k6 login cloud Aug 19, 2025
@mstoykov mstoykov merged commit 4170fd4 into v1.2.x Aug 19, 2025
36 of 37 checks passed
@mstoykov mstoykov deleted the backport5057 branch August 19, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants