[bugfix] aws_controltower_landing_zone: Fixes issue where updates are always detected for manifest retentionDays attribute

[calxus]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Resolves an issue in the aws_controltower_landing_zone resource where the attribute retentionDays in the landing zone manifest needs to be defined as an integer in order to create or update the resource.

However it is converted to a string when the manifest is read from AWS so drift is always detected unless you modify your local manifest to set the attribute as a string. But then you can not update the resource again without changing it to a integer.

Relations

Relates #35763

References

Output from Acceptance Testing

I'm not able to run acceptance tests for control tower in my sandbox environment, I have written the test though and the logic I think makes sense. It was mentioned in the docs that the tests can be run on your side so if that is possible, that would be great!

...

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.