-
Notifications
You must be signed in to change notification settings - Fork 10k
Decode action blocks and action_triggers inside resource blocks. #37030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02b68a9
to
53cbaed
Compare
53cbaed
to
5d35533
Compare
5d35533
to
5725fe7
Compare
DanielMSchmidt
previously approved these changes
May 13, 2025
jbardin
reviewed
May 13, 2025
848f3f6
to
064e70c
Compare
This commit adds decoding of action and action_triggers inside terraform configuration. I added an Actions experiment as a hacky way of keeping the functionality out of main until we're ready for the alpha; this may never be an experiment but it's a handy feature flag so we don't have to do all the work in a long-lived feature branch. This isn't *complete* so much as a useful checkpoint for reviewing as we build out Actions.
6dd1b2d
to
839a861
Compare
DanielMSchmidt
approved these changes
May 14, 2025
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds decoding and merging action and action_triggers inside terraform configuration. The merging behavior is consistent with other terraform objects (the very short version: attributes merge, blocks override). This is likely incomplete, but a good starting point for reviews.
I added an Actions experiment as a somewhat hacky way of keeping the functionality suppressed until we're ready for the alpha; this may never be a formal "experiment" but it's a handy feature-flag-ish-thing so we don't have to do all the work in a long-lived feature branch. (It doesn't matter much at this phase, but once we start adding action functionality this will be important). I will remove
experimentsAllowed
from thedecodeResourceBlock
method signature as soon as this is complete.And for ✨ extra confirmation ✨ that none of this is user-facing, terraform (built from this branch) ignores any
action
blocks it finds: this works just fineCHANGELOG entry