PSS: Add savedStateStore method to Meta
#37558
Open
+234
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
changed the title
savedStateStore method to Meta
SarahFrench
added
the
no-changelog-needed
SarahFrench
commented
Sep 3, 2025
Comment on lines
+1616
to
+1618
| // Validate and configure the provider | ||
| validateResp := provider.ValidateProviderConfig(providers.ValidateProviderConfigRequest{ | ||
| Config: providerConfigVal, |
There was a problem hiding this comment.
I believe we don't need to consider marks here as the data is coming from the backend state file (which cannot store marks), but if we were configuring the state store from configuration then we would need to consider marks here. Just flagging for discussion with reviewer(s).
SarahFrench
force-pushed
the
pss/add-saved-state-store-method
branch
from
03793cc to
678807b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
savedStateStoremethod that's similar to the existingsavedBackendmethod onMeta.The
savedBackendmethod on Meta returns a backend that's configured using the backend state file's contents and isn't influenced by the current config. This method is used during state migration events ininitcommands, where Terraform needs to have an instance of the old backend, configured the old way, in order to access state to migrate to the new backend's location.Note: There is a variant called
backendFromStatethat does a similar job but isn't considered in this PR. This variant is specific to users running init commands with-backend=falseas a flag.This PR adds a new
savedStateStoremethod that's similar to the existingsavedBackendmethod onMeta. The method uses only backend state file data to configure and return a backend.Backend instance made using a provider that implements pluggable state storage.Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry