Improve BLOCKHASH Short Circuit #8171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve efficiency of the blockhash range checking by only testing the soughtBlock. Signed-off-by: Danno Ferrin <danno@numisight.com>
garyschulte
reviewed
Jan 24, 2025
Comment on lines
60
to
62
| // If the current block is the genesis block or the sought block is | ||
| // not within the lookback window, zero is returned. | ||
| if (currentBlockNumber == 0 | ||
| if (soughtBlock < 0 |
There was a problem hiding this comment.
the comment for this condition is no longer accurate
garyschulte
approved these changes
Jan 24, 2025
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Jan 31, 2025
* Improve BLOCKHASH Short Circuit Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
github-merge-queue bot
pushed a commit
to Consensys/protocols-release-sandbox
that referenced
this pull request
Feb 4, 2025
* fixes syntax errors (hyperledger#8164) Signed-off-by: jflo <justin+github@florentine.us> * Pectra testnet fork slots (hyperledger#8163) * adds Prague slot times Signed-off-by: jflo <justin+github@florentine.us> --------- Signed-off-by: jflo <justin+github@florentine.us> * Check if discovery service is running before `admin_addPeer` (hyperledger#8160) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> * update eth_call error message (hyperledger#8129) Signed-off-by: Karim Taam <karim.t2am@gmail.com> * Refactor the methods for getting mutable states in the WorldState provider (hyperledger#8113) Refactor the methods for retrieving mutable states in the WorldState provider and make additional improvements to clean up the code. --------- Signed-off-by: Karim Taam <karim.t2am@gmail.com> * Extend simulate transaction on pending block plugin API (hyperledger#8174) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * debug_traceBlock use existing block header instead of hash (hyperledger#8184) This means you don't need to have the block already in the chain when you call debug_traceBlock with a block's RLP (you just need the parent). Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * fixes warning on sonar analysis (hyperledger#8193) Signed-off-by: jflo <justin+github@florentine.us> * add spotless to PR checklist (hyperledger#8185) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Reuse constant INVALID_PARAMS_ERROR_CODE for RpcErrorType.java (hyperledger#8154) Magic number "-32602" has been defined in the super interface, so reusing that constant value. Signed-off-by: Andrew Cheng <andrewcheng1997@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Improve BLOCKHASH Short Circuit (hyperledger#8171) * Improve BLOCKHASH Short Circuit Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> * TransactionResult: add v for blob and pending tx (hyperledger#8196) * add v for blob and pending tx Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * add v for blob and pending tx in tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * add v for blob tx in test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Prague t8n and referenceTests fixes for EEST (hyperledger#8167) Fix referenceTests bug with fallback EMPTY Address. T8n support for excessBlobGas for both state tests and blockchain test. State tests should use the given excessBlobGas rather than computing from the parent header. Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * disable fast sync actions test Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Andrew Cheng <andrewcheng1997@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Andrew Cheng <andrewcheng1997@gmail.com> Co-authored-by: Danno Ferrin <danno@numisight.com>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
* Improve BLOCKHASH Short Circuit Signed-off-by: Danno Ferrin <danno@numisight.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improve efficiency of the blockhash range checking by only testing the soughtBlock.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests