Get partition labels from udev #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly reuses the udevInfo method to obtain the udev info for a given partition in a given disk instead of having the label value always empty. This separates the udevInfo method into 2 distinct methods, one for disk and one for partition. This also opens the possibility of obtaining more info for partitions, i.e. the FS of an unmounted partition. Signed-off-by: Itxaka <igarcia@suse.com>
|
thanks @Itxaka , looks good! any chance to add unit tests to cover this change? |
|
Sure! |
Signed-off-by: Itxaka <igarcia@suse.com>
|
@fromanirh tests added :) |
ffromani
reviewed
Mar 18, 2022
|
@Itxaka thanks very much for your contribution! really appreciated! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly reuses the udevInfo method to obtain the udev info for a
given partition in a given disk instead of having the label value always
empty.
This separates the udevInfo method into 2 distinct methods, one for disk
and one for partition.
This also opens the possibility of obtaining more info for partitions,
i.e. the FS of an unmounted partition.
Signed-off-by: Itxaka igarcia@suse.com