Update core dependencies, Dockerfile, fix error in run-against-snapshot #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this change! at glance LGTM, I'll have a proper review asap |
Signed-off-by: Tai Groot <tai@taigrr.com>
|
@jaypipes was fast, I was about to approve :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to validate a snapshot created for #293 , I ran into issues using the run-against-snapshot script. It seems some of the tags for the dependencies were removed upstream, preventing the container from building.
Additionally, there was a bug in the script preventing it from running without an environment variable being set.
Finally, stretch has been unsupported for over a year at this point, and the CA store was causing issues downloading from package registries, so I updated the base image to buster, and the go tag to 1.15 from 1.13 to match the go.mod