Fixes #267 dont compare pointer addresses #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @viocle-kvanek! Thank you for the contribution! Would you mind signing your commit ( |
Signed-off-by: Kyle <kyle@viocle.com>
Signed-off-by: Kyle <kyle@viocle.com>
|
the change itself looks good. Let's maybe check (possibly in another PR) that this flow is covered by tests |
|
Hi @viocle-kvanek ! to make the DCO check pass, could you please sign both of your commits 8e44bc2 and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows partitions will not populate correctly because the disk index on drive and partition are being compared using the pointer address, not the value.