Add more fields to NIC #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
requested changes
May 4, 2023
jaypipes
reviewed
May 8, 2023
There was a problem hiding this comment.
@jak3kaj how's it going? I wanted to know if you think you can fix up this PR today? I was looking to cut a new release of ghw today and wanted to get this excellent work into the release :)
I think the only thing you need to do is rebase and remove the now-uncalled functions.
SupportedFECModes, AdvertisedLinkModes, AdvertisedFECModes to NIC struct. Update test case to validate new fields. Update README. Signed-off-by: Jacob Young <jacoby@nvidia.com>
Update ParseBool to return `false` for empty strings. Signed-off-by: Jacob Young <jacoby@nvidia.com>
Signed-off-by: Jacob Young <jacoby@nvidia.com>
Co-authored-by: Jay Pipes <jaypipes@gmail.com> Signed-off-by: Jacob Young <jacoby@nvidia.com>
Co-authored-by: Jay Pipes <jaypipes@gmail.com> Signed-off-by: Jacob Young <jacoby@nvidia.com>
Signed-off-by: Jacob Young <jacoby@nvidia.com>
Signed-off-by: Jacob Young <jacoby@nvidia.com>
Signed-off-by: Jacob Young <jacoby@nvidia.com>
I'm working on the 3rd PR to add support for the WOL data. I can move |
ffromani
reviewed
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following to the
NICstruct:SpeedDuplexSupportedLinkModesSupportedPortsSupportedFECModesAdvertisedLinkModesAdvertisedFECModesRefactoring PR #335