fix: Refactor OpenDestination func #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gofastasf
commented
Feb 2, 2025
Gofastasf
commented
- Replaced os.Stat call and os.Create with os.OpenFile with O_EXCL to avoid TOCTOU.
- Improved logic to handle file size check only when the file exists.
Gofastasf
force-pushed
the
fix/OpenDestination-func
branch
from
45b9602 to
63219da
Compare
- Replaced os.Stat call and os.Create with os.OpenFile with O_EXCL to avoid TOCTOU. - Improved logic to handle file size check only when the file exists. Signed-off-by: Gofastasf <gofastasf@gmail.com>
Gofastasf
force-pushed
the
fix/OpenDestination-func
branch
from
63219da to
db5e7e1
Compare
jaypipes
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.