Improve string and file extension handling: ReplaceAll & filepath.Ext #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced os.Stat call and os.Create with os.OpenFile with O_EXCL to avoid TOCTOU. - Improved logic to handle file size check only when the file exists. Signed-off-by: Gofastasf <gofastasf@gmail.com>
Signed-off-by: Gofastasf <gofastasf@gmail.com>
Gofastasf
force-pushed
the
update-code
branch
from
f2a0745 to
31deeaf
Compare
Signed-off-by: Gofastasf <gofastasf@gmail.com>
|
@Gofastasf please rebase this to main and update your PR summary :) thank you! |
Gofastasf
changed the title
jaypipes
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Sorry for the long delay in merging this @Gofastasf, approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced strings.Replace with updated strings.ReplaceAll
Use filepath.Ext for file extension instead of strings.HasSuffix.