Skip to content

Conversation

jaypipes
Copy link
Owner

Updates the third-party dependencies in order for importing projects that have stricter dependency compliance restrictions.

For github.com/jaypipes/pcidb, uplifts it to the latest 1.1.0 release, which removed the archived github.com/mitchellh/go-homedir dependency.

For howett.net/plist, there hasn't been a tagged release of that repo since December, 2023, so I manually go get the latest commit from January 2025 for that repository. howett.net/plist is used for MacOS support.

For github.com/StackExchange/wmi, I changed this to github.com/yusufpapurcu/wmi which is the officially-supported fork of the github.com/StackExchange/wmi repo.

Closes Issue #323
Related Issue jaypipes/pcidb#36
Related google/dranet#194

Updates the third-party dependencies in order for importing projects
that have stricter dependency compliance restrictions.

For `github.com/jaypipes/pcidb`, uplifts it to the latest 1.1.0 release,
which removed the archived `github.com/mitchellh/go-homedir` dependency.

For `howett.net/plist`, there hasn't been a tagged release of that repo
since December, 2023, so I manually `go get` the latest commit from
January 2025 for that repository. `howett.net/plist` is used for MacOS
support.

For `github.com/StackExchange/wmi`, I changed this to
`github.com/yusufpapurcu/wmi` which is the officially-supported fork of
the `github.com/StackExchange/wmi` repo.

Closes Issue #323
Related Issue jaypipes/pcidb#36
Related google/dranet#194

Signed-off-by: Jay Pipes <jaypipes@gmail.com>
@jaypipes
Copy link
Owner Author

@ffromani lemme know if you have any objections on this one. I'll merge it if not and cut a new release.

@@ -6,7 +6,7 @@
package baseboard

import (
"github.com/StackExchange/wmi"
"github.com/yusufpapurcu/wmi"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the README on "github.com/StackExchange/wmi" recommends this fork, so it seems fine

Copy link
Collaborator

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffromani
Copy link
Collaborator

@ffromani lemme know if you have any objections on this one. I'll merge it if not and cut a new release.

no objections, thanks for the update!

@jaypipes jaypipes merged commit 0dc4664 into main Aug 24, 2025
17 checks passed
@jaypipes jaypipes deleted the deps branch August 24, 2025 13:58
@jaypipes
Copy link
Owner Author

Thanks @ffromani! :)

Copy link

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

github.com/pkg/errors v0.9.1
github.com/spf13/cobra v1.8.0
github.com/spf13/cobra v1.9.1
github.com/yusufpapurcu/wmi v1.2.4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this better? we moved to a single-maintainer dependency with a PR open since april with no comments:
yusufpapurcu/wmi#10
last commit and release 1.5 years ago

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder yeah, I know :( lack of options in this space, unfortunately. I've been considering creation of a library myself that interfaces with WMI, but haven't found the time to dedicate to Windows development...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants