-
Notifications
You must be signed in to change notification settings - Fork 198
uplift all third-party dependencies #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the third-party dependencies in order for importing projects that have stricter dependency compliance restrictions. For `github.com/jaypipes/pcidb`, uplifts it to the latest 1.1.0 release, which removed the archived `github.com/mitchellh/go-homedir` dependency. For `howett.net/plist`, there hasn't been a tagged release of that repo since December, 2023, so I manually `go get` the latest commit from January 2025 for that repository. `howett.net/plist` is used for MacOS support. For `github.com/StackExchange/wmi`, I changed this to `github.com/yusufpapurcu/wmi` which is the officially-supported fork of the `github.com/StackExchange/wmi` repo. Closes Issue #323 Related Issue jaypipes/pcidb#36 Related google/dranet#194 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
@ffromani lemme know if you have any objections on this one. I'll merge it if not and cut a new release. |
@@ -6,7 +6,7 @@ | |||
package baseboard | |||
|
|||
import ( | |||
"github.com/StackExchange/wmi" | |||
"github.com/yusufpapurcu/wmi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the README on "github.com/StackExchange/wmi" recommends this fork, so it seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
no objections, thanks for the update! |
Thanks @ffromani! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
github.com/pkg/errors v0.9.1 | ||
github.com/spf13/cobra v1.8.0 | ||
github.com/spf13/cobra v1.9.1 | ||
github.com/yusufpapurcu/wmi v1.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this better? we moved to a single-maintainer dependency with a PR open since april with no comments:
yusufpapurcu/wmi#10
last commit and release 1.5 years ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenTheElder yeah, I know :( lack of options in this space, unfortunately. I've been considering creation of a library myself that interfaces with WMI, but haven't found the time to dedicate to Windows development...
Updates the third-party dependencies in order for importing projects that have stricter dependency compliance restrictions.
For
github.com/jaypipes/pcidb
, uplifts it to the latest 1.1.0 release, which removed the archivedgithub.hdec.top/mitchellh/go-homedir
dependency.For
howett.net/plist
, there hasn't been a tagged release of that repo since December, 2023, so I manuallygo get
the latest commit from January 2025 for that repository.howett.net/plist
is used for MacOS support.For
github.com/StackExchange/wmi
, I changed this togithub.hdec.top/yusufpapurcu/wmi
which is the officially-supported fork of thegithub.hdec.top/StackExchange/wmi
repo.Closes Issue #323
Related Issue jaypipes/pcidb#36
Related google/dranet#194