-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Report warning when @SuiteDisplayName
is blank
#4822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcphilipp
merged 5 commits into
junit-team:main
from
raccoonback:4810-inspect-blank-suite-display-name
Aug 12, 2025
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
66bb647
Add inspection for blank @SuiteDisplayName values
raccoonback 9f9ef0e
Update @since version for blank and whitespace-only @SuiteDisplayName…
raccoonback d05b18d
Refactor suite display name retrieval to include issue reporting for …
raccoonback fe11176
Fix typo
marcphilipp 59c5f25
Polish assertion
marcphilipp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
.../src/test/java/org/junit/platform/suite/engine/testsuites/BlankSuiteDisplayNameSuite.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright 2015-2025 the original author or authors. | ||
* | ||
* All rights reserved. This program and the accompanying materials are | ||
* made available under the terms of the Eclipse Public License v2.0 which | ||
* accompanies this distribution and is available at | ||
* | ||
* https://www.eclipse.org/legal/epl-v20.html | ||
*/ | ||
|
||
package org.junit.platform.suite.engine.testsuites; | ||
|
||
import org.junit.platform.suite.api.SelectClasses; | ||
import org.junit.platform.suite.api.Suite; | ||
import org.junit.platform.suite.api.SuiteDisplayName; | ||
import org.junit.platform.suite.engine.testcases.SingleTestTestCase; | ||
|
||
/** | ||
* Test suite with blank @SuiteDisplayName to verify validation. | ||
* | ||
* @since 6.0 | ||
*/ | ||
@Suite | ||
@SelectClasses(SingleTestTestCase.class) | ||
@SuiteDisplayName("") | ||
public class BlankSuiteDisplayNameSuite { | ||
} |
27 changes: 27 additions & 0 deletions
27
...test/java/org/junit/platform/suite/engine/testsuites/WhitespaceSuiteDisplayNameSuite.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright 2015-2025 the original author or authors. | ||
* | ||
* All rights reserved. This program and the accompanying materials are | ||
* made available under the terms of the Eclipse Public License v2.0 which | ||
* accompanies this distribution and is available at | ||
* | ||
* https://www.eclipse.org/legal/epl-v20.html | ||
*/ | ||
|
||
package org.junit.platform.suite.engine.testsuites; | ||
|
||
import org.junit.platform.suite.api.SelectClasses; | ||
import org.junit.platform.suite.api.Suite; | ||
import org.junit.platform.suite.api.SuiteDisplayName; | ||
import org.junit.platform.suite.engine.testcases.SingleTestTestCase; | ||
|
||
/** | ||
* Test suite with whitespace-only @SuiteDisplayName to verify validation. | ||
* | ||
* @since 6.0 | ||
*/ | ||
@Suite | ||
@SelectClasses(SingleTestTestCase.class) | ||
@SuiteDisplayName(" ") | ||
public class WhitespaceSuiteDisplayNameSuite { | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.