Add features to kpt live status command #3353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunglu-chou
requested review from
droot,
justinsb,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
nan-yu
reviewed
Jul 8, 2022
| } | ||
| switch ep.Format { | ||
| case printers.EventsPrinter: | ||
| _, err := fmt.Printf("%s/%s/%s/%s is %s: %s\n", invName, |
There was a problem hiding this comment.
fmt.Printf prints to os.Stdout directly. However, the underlying cli-utils library prints to ioStreams.Out, which is os.Stdout in most cases, but it can also be other streams.
I guess we need to wait for @mortent on how to proceed with the deviated fork. If we decide to go with the major changes in the forked cli-utils, it's better to pass along ioStreams for printing.
| @@ -77,7 +73,7 @@ func NewRunner(ctx context.Context, factory util.Factory) *Runner { | |||
| "How long to wait before exiting") | |||
| c.Flags().BoolVar(&r.list, "list", false, "List status of all packages or not") | |||
| c.Flags().StringVar(&r.inventoryNames, "inv-name", "", "names of targeted inventory: inv1,inv2,...") | |||
| c.Flags().StringVar(&r.namespaces, "namespace", "", "names of targeted namespaces: ns1,ns2,...") | |||
| c.Flags().StringVar(&r.namespaces, "namespaces", "", "names of targeted namespaces: ns1,ns2,...") | |||
| c.Flags().StringVar(&r.status, "status", "", "targeted status: st1,st2...") | |||
chunglu-chou
force-pushed
the
event-and-json
branch
from
97d0892 to
2644584
Compare
…mespace, and inventory name. Add a new column in table format showing the inventory name.
…ve unused functions and constants.
chunglu-chou
force-pushed
the
event-and-json
branch
from
2644584 to
89975ab
Compare
|
Is this a dupe of #3345? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better support the listing status functionality, the following things are updated: