Skip to content

Publish JobSet v0.9.0 #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Publish JobSet v0.9.0 #8453

wants to merge 2 commits into from
+4 −2

Conversation

andreyvelich
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kannon92 August 28, 2025 17:52
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2025
kannon92
kannon92 reviewed Aug 28, 2025
View reviewed changes
registry.k8s.io/images/k8s-staging-jobset/images.yaml
@@ -27,3 +28,4 @@
"sha256:ad87d7473051593ab6419c464f17641ed91607721a7dd841d5be5534b1faf3d2": ["v0.8.0"]
"sha256:7b8a2ed7fd4c8ea3960fc16623d3328e30b7472c9166e434bea9448eb974ff32": ["v0.8.1"]
"sha256:a25804af6def03d794c218930176c5dac12b5de06a450e38b8a15143a6fd0071": ["v0.8.2"]
"sha256:eeef77bf8f7548ad3727a1c1f68baf0eaf95dca52bc319ce1c69505a67244584": ["v0.9.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

kehannon@kehannon-thinkpadp1gen4i:~/Work/k8s.io$ podman inspect us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:v0.9.0
[
     {
          "Id": "365d2d4c6a14667df0e77991350e752485dfbc1bd3fe137d18c65d7d055a82b0",
          "Digest": "sha256:0aaf9c6f00f303a5587359824230b3017f25984e1b089118b6ea05501449fac1",
          "RepoTags": [
               "us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:v0.9.0"
          ],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for me docker shows different digest, like here: https://console.cloud.google.com/artifacts/docker/k8s-staging-images/us-central1/jobset/jobset/sha256:eeef77bf8f7548ad3727a1c1f68baf0eaf95dca52bc319ce1c69505a67244584

$ docker inspect us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:v0.9.0
[
    {
        "Id": "sha256:eeef77bf8f7548ad3727a1c1f68baf0eaf95dca52bc319ce1c69505a67244584",
        "RepoTags": [
            "us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:v0.9.0"
        ],
  }
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.

Not really sure the differences between podman/docker.

[
     {
          "Id": "365d2d4c6a14667df0e77991350e752485dfbc1bd3fe137d18c65d7d055a82b0",
          "Digest": "sha256:0aaf9c6f00f303a5587359824230b3017f25984e1b089118b6ea05501449fac1",
          "RepoTags": [
               "us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset:v0.9.0"
          ],
          "RepoDigests": [
               "us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset@sha256:0aaf9c6f00f303a5587359824230b3017f25984e1b089118b6ea05501449fac1",
               "us-central1-docker.pkg.dev/k8s-staging-images/jobset/jobset@sha256:eeef77bf8f7548ad3727a1c1f68baf0eaf95dca52bc319ce1c69505a67244584"
          ],

I meant to say that I can confirm this exists. Just making sure we promote a tag that can pull.

kannon92
kannon92 reviewed Aug 28, 2025
View reviewed changes
registry.k8s.io/images/k8s-staging-jobset/images.yaml Outdated
@@ -2,6 +2,7 @@
dmap:
"sha256:9799666207d23a6d3c9d4ec50d7cf6c79f290f5c31ef7d03f87f0c6fcb635e61": ["v0.8.1"]
"sha256:4ce7e93faa6358de8862fd9fc05d714ab7f499e1e905dfb38b5ddff1db7b1053": ["v0.8.2"]
"sha256:f467a871202b7e1f2f6fc5eeba00de929db2e5e3313813a292d535d2786c79eb": ["v0.9.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

kehannon@kehannon-thinkpadp1gen4i:~/Work/k8s.io$ helm template oci://us-central1-docker.pkg.dev/k8s-staging-images/jobset/charts/jobset --version v0.9.0 | grep registry.k8s.io
Pulled: us-central1-docker.pkg.dev/k8s-staging-images/jobset/charts/jobset:v0.9.0
Digest: sha256:f467a871202b7e1f2f6fc5eeba00de929db2e5e3313813a292d535d2786c79eb
        image: "registry.k8s.io/jobset/jobset:v0.9.0"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is good! This is what we expect.

@kannon92
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@kannon92
Copy link
Contributor

@tenzen-y waiting on your response. If you are fine with this, we’d like to get a JobSet release out.

@tenzen-y
Copy link
Member

Why we should use 0.9.0 version for the Helm Charts ?

kubernetes-sigs/kueue#4445

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@andreyvelich
Remove v prefix for JobSet Helm charts
bbe2a12 
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

andreyvelich commented Aug 29, 2025 •
edited
Loading

Thanks for the info @tenzen-y!
I confirmed that this doesn't work for me:

$ helm show chart oci://registry.k8s.io/jobset/charts/jobset
Error: failed to download "oci://registry.k8s.io/jobset/charts/jobset"

But this works:

$ helm show chart oci://registry.k8s.io/jobset/charts/jobset --version v0.8.2
apiVersion: v2
appVersion: v0.8.2

As I can see in this PR you didn't break the old version of Kueue Helm charts: #7877.
However, after the migration, you've removed them: https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-kueue/images.yaml#L29

Do you know why you did that @mimowo @tenzen-y ?

@tenzen-y
Copy link
Member

The registry.k8s.io does not allow us to break existing tags.
In other words, infra mechanism does not implement TAG update API.
So, even if you break the existing TAGs in your configuration, anything does not occur.

@andreyvelich
Copy link
Member Author

The registry.k8s.io does not allow us to break existing tags.

Thanks for the info @tenzen-y!
Do you know if it allows to add one more tag to the existing releases: ["v0.8.1", "0.8.1"] ?

@tenzen-y
Copy link
Member

The registry.k8s.io does not allow us to break existing tags.

Thanks for the info @tenzen-y!

Do you know if it allows to add one more tag to the existing releases: ["v0.8.1", "0.8.1"] ?

That should work well.
If that does not work, you will be noticed by bot after this PR is merged.

@andreyvelich
Copy link
Member Author

@kannon92 @ahg-g @GiuseppeTT Shall we merge this PR and see if that works ?

@tenzen-y
Copy link
Member

@kannon92 @ahg-g @GiuseppeTT Shall we merge this PR and see if that works ?

We should check if staging OCI chart image has correct chart version semantic before merge.

@tenzen-y
Copy link
Member

Incorrect: https://github.com/kubernetes-sigs/jobset/blob/a3751fd1cda694677c896f291c1992a91d497cbf/charts/jobset/Chart.yaml#L24

@andreyvelich
Copy link
Member Author

Incorrect: https://github.com/kubernetes-sigs/jobset/blob/a3751fd1cda694677c896f291c1992a91d497cbf/charts/jobset/Chart.yaml#L24

@tenzen-y What changes do we require to make ? I can see that Kueue has similar version: https://github.com/kubernetes-sigs/kueue/blob/main/charts/kueue/Chart.yaml#L19

@tenzen-y
Copy link
Member

Incorrect: https://github.com/kubernetes-sigs/jobset/blob/a3751fd1cda694677c896f291c1992a91d497cbf/charts/jobset/Chart.yaml#L24

@tenzen-y What changes do we require to make ? I can see that Kueue has similar version: https://github.com/kubernetes-sigs/kueue/blob/main/charts/kueue/Chart.yaml#L19

That should be 0.9.0

@tenzen-y
Copy link
Member

https://github.com/kubernetes-sigs/jobset/blob/v0.9.0/charts/jobset/Chart.yaml

@andreyvelich
Copy link
Member Author

andreyvelich commented Aug 29, 2025 •
edited
Loading

I see, so we incorrectly tag the release commit.
@kannon92 @tenzen-y We should tag this commit with v0.9.0: kubernetes-sigs/jobset@079c7ff

Do we know, if we are going to re-tag it, will the SHAs get updated in the OCI registry ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreyvelich @kannon92 @k8s-ci-robot @tenzen-y