feat!: add packages input that installs packages on the AWS instance as part of cloud-init #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are cases where this change does not work. I'm closing for now, might reopen with updated code. |
|
Hi @Preen, this is ready for review. I ran this with workflows that auto-install the runner on: and with a pre-runner script + packages: |
|
fyi I re-tested after merging the main branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing packages in the
pre-runner-scripthas been unreliable as it seems during boot there are other processes locking the package index. It appears the recommended way is to use thepackagesproperty of cloud-init.This requires passing a cloud init YAML (starts with
#cloud-config) as user data. Luckily this format is supported by AWS.This PR:
pre-runner-script.shand the main user-data script (runner-setup.sh) using cloud-init'swrite_filespackagesdirective to install packagesruncmdThis allows supporting multi-line pre-runner-script.sh. As a bonus, this greatly simplified strange escaping issues stemming from
echo "${config.input.preRunnerScript}" > pre-runner-script.sh-- we tried to write a file inside the pre-runner-script which required multiple levels of nested escaping before this change, now this burden is greatly reduced.Additionally, this PR causes the package, when installing the github runner, to install the latest version. Otherwise I've seen the runner updates itself on load, increasing the startup time. I thought this might be causing some issues while debugging the feature and added this according to github instructions. Since this works, I think we might as well merge this too and enjoy the reduced startup time.