Skip to content

Conversation

l-gosling
Copy link
Contributor

@l-gosling l-gosling commented Sep 1, 2025

Description

Refactor: Add role descriptions to AdministrativeRolesToCheck, rearrange and fix typo in grantControls.

Changed from
$policy.grantControls.buildInControls
to
$policy.grantControls.builtInControls

Solve parts of:
#1054

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Read the guidelines for contributions

PRs related to all code

  • Before you submit the PR, run the tests locally by running /powershell/tests/pester.ps1
  • After submitting, verify the tests are still passing on your PR in GitHub (the tests are run across all platforms).

PRs related to Maester Tests

If you are contributing a test or making updates to a test please verify these.

  • Add Test with your .ps1 and .md-file (make sure .ps1 file is encoded with "UTF8 with BOM") .\powershell\public\maester...
  • Add your new test-function to a corresponding .test.ps1 file \tests\Maester..*.test.ps1
  • Add your new test-function to 'FunctionsToExport'-List .\powershell\Maester.psd1
  • Add test Id, Severity and Title to "maester-config.json" file .\tests\maester-config.json
  • Add website documentation for test with name of "testId.md" .\website\docs\tests\maester
  • If Invoke-Maester parameters are changed, update the GitHub action to use the new parameters.

Review

We will try to review your pull request as soon as possible. If you have any queries or need any help please jump on Discord. We really appreciate your contributions!

💖 Thank you!

@l-gosling l-gosling requested a review from a team as a code owner September 1, 2025 17:49
@l-gosling l-gosling changed the title Refactor: Add role descriptions to AdministrativeRolesToCheck, rearra… Fix: MT.1014 typo in builtInControls Sep 1, 2025
Copy link
Contributor

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers tx @l-gosling can't believe we missed that one.

@merill merill merged commit 5c47d05 into maester365:main Sep 1, 2025
4 checks passed
@l-gosling l-gosling deleted the Bugfix--MT.1014---Issue--1054 branch September 6, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants