Include path in hash of file. #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for two separate files to have the same contents but different data about the file, like path, what module it belongs to, etc. This includes the filename and the file contents in the hash that we calculate to determine uniqueness, so that different files with the same contents will be cached in different files.
martinheidegger
requested changes
Feb 15, 2018
There was a problem hiding this comment.
Thank you for the PR. As per #3 (comment), i would ask for this PR to make the file hash as an option (default: true) and that option would need a little documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
This uses the path of the file in addition to the content of the file to ensure that each input file gets cached at a unique location.