Skip to content

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 30, 2024

Scalability test is currently running with hardcoded number of clusters and number of clusters provisioned in parallel (both are set to 5). Also, the number of clusters cannot be lower than the number of fake nodes set by dev-env, but so far we have not taken it into account.

We should parameterize these numbers, and use the NUM_NODES param from dev-env as number of clusters. This could change in the future, when we include multi-node clusters into scalability test, but that won't likely happen in a near future.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2024
@mquhuy mquhuy force-pushed the mquhuy/parameterize-scalability branch 5 times, most recently from 71a9aa1 to 2888c52 Compare January 2, 2025 10:17
@mquhuy
Copy link
Member Author

mquhuy commented Jan 3, 2025

@mquhuy
Copy link
Member Author

mquhuy commented Jan 3, 2025

/cc @Rozzii @adilGhaffarDev @Sunnatillo

@mquhuy
Copy link
Member Author

mquhuy commented Jan 3, 2025

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

Scalability test is currently running with hardcoded number of clusters and number of clusters provisioned in parallel (both are set to 5). Also, the number of clusters cannot be lower than the number of fake nodes set by dev-env, but so far we have not taken it into account.

We should parameterize these numbers, and use the NUM_NODES param from dev-env as number of clusters. This could change in the future, when we include multi-node clusters into scalability test, but that won't likely happen in a near future.

Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/parameterize-scalability branch from 2888c52 to 7f7c8df Compare January 3, 2025 13:34
@mquhuy
Copy link
Member Author

mquhuy commented Jan 3, 2025

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mquhuy mquhuy requested a review from adilGhaffarDev January 7, 2025 08:18
@adilGhaffarDev
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@metal3-io-bot metal3-io-bot merged commit cf75cf8 into metal3-io:main Jan 7, 2025
14 of 15 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/parameterize-scalability branch January 7, 2025 08:26
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Jan 7, 2025
@mquhuy
Copy link
Member Author

mquhuy commented Jan 9, 2025

/cherry-pick release-1.9

@metal3-io-bot
Copy link
Contributor

@mquhuy: new pull request created: #2233

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants