-
Notifications
You must be signed in to change notification settings - Fork 113
🌱 Parameterize scalability test #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Parameterize scalability test #2202
Conversation
71a9aa1
to
2888c52
Compare
/test metal3-ubuntu-e2e-integration-test-main |
Scalability test is currently running with hardcoded number of clusters and number of clusters provisioned in parallel (both are set to 5). Also, the number of clusters cannot be lower than the number of fake nodes set by dev-env, but so far we have not taken it into account. We should parameterize these numbers, and use the NUM_NODES param from dev-env as number of clusters. This could change in the future, when we include multi-node clusters into scalability test, but that won't likely happen in a near future. Signed-off-by: Huy Mai <huy.mai@est.tech>
2888c52
to
7f7c8df
Compare
/test metal3-ubuntu-e2e-integration-test-main |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@mquhuy: new pull request created: #2233 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Scalability test is currently running with hardcoded number of clusters and number of clusters provisioned in parallel (both are set to 5). Also, the number of clusters cannot be lower than the number of fake nodes set by dev-env, but so far we have not taken it into account.
We should parameterize these numbers, and use the NUM_NODES param from dev-env as number of clusters. This could change in the future, when we include multi-node clusters into scalability test, but that won't likely happen in a near future.