🌱 Update e2e tests to use capi v1.10.0-beta.1 and uplift go mods to v1.10.0-beta.1 #2462
Conversation
metal3-io-bot
added
the
size/S
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/test ? |
|
@adilGhaffarDev: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-centos-e2e-basic-test-main /test metal3-centos-e2e-feature-test-main-features /test metal3-centos-e2e-feature-test-main-pivoting /test metal3-centos-e2e-feature-test-main-remediation |
|
/test metal3-centos-e2e-feature-test-main-features |
test/e2e/config/e2e_conf.yaml
Outdated
| - name: "{go://sigs.k8s.io/cluster-api@latest-v1.10}" | ||
| value: "https://storage.googleapis.com/k8s-staging-cluster-api/components/{go://sigs.k8s.io/cluster-api@latest-v1.10}/core-components.yaml" | ||
| type: "url" | ||
| contract: v1beta1 | ||
| files: | ||
| - sourcePath: "../data/shared/v1.10/metadata.yaml" | ||
| replacements: | ||
| - old: --metrics-addr=127.0.0.1:8080 | ||
| new: --metrics-addr=:8080 |
There was a problem hiding this comment.
I guess we should add also the bootstrap and control-plane providers?
Also, could we remove some of the older versions? Do we need v1.5 for example?
adilGhaffarDev
force-pushed
the
bump-capi-1.10beta0-e2e/adil
branch
from
dcd7e97 to
8c84fab
Compare
metal3-io-bot
added
needs-rebase
adilGhaffarDev
force-pushed
the
bump-capi-1.10beta0-e2e/adil
branch
from
8c84fab to
76c5dec
Compare
metal3-io-bot
removed
the
needs-rebase
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main /test metal3-centos-e2e-feature-test-main-pivoting |
|
/test metal3-centos-e2e-feature-test-main-pivoting |
|
/cc @kashifest @lentzi90 |
|
beta.1 was released last week, perhaps we shall use that ? https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.10.0-beta.1 |
There was a problem hiding this comment.
Could you please keep the indent style? It would be much easier to see what changed and we try to stick to the same style everywhere
There was a problem hiding this comment.
I think now all of them are fixed, please check. let me know if anything is missed.
test/e2e/config/e2e_conf.yaml
Outdated
| loadBehavior: mustLoad | ||
| - name: quay.io/metal3-io/ip-address-manager:latest | ||
| loadBehavior: mustLoad | ||
| # Use local dev images built source tree; |
There was a problem hiding this comment.
We used k8s indents, so what it was before. Reconfigure your yaml formatter.
adilGhaffarDev
force-pushed
the
bump-capi-1.10beta0-e2e/adil
branch
4 times, most recently
from
fc19550 to
d3f6128
Compare
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
adilGhaffarDev
force-pushed
the
bump-capi-1.10beta0-e2e/adil
branch
from
d3f6128 to
3e5ea19
Compare
adilGhaffarDev
changed the title
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
What this PR does / why we need it:
Update e2e tests to use capi v1.10.0-beta.1.
uplift go mods to v1.10.0-beta.1
This is also removing
shared/main/metadata.yamlfrom e2e tests, this is not used anywhere because we don't test capi main, it is just confusing. We can add it again if we decide to test capi main.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #