Skip to content

🌱 add labels to Dockerfile #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

🌱 add labels to Dockerfile #2483

merged 1 commit into from
Apr 9, 2025

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Apr 4, 2025 •
edited
Loading

Add org.opencontainers labels to Dockerfile. image.version will be set by automation.

Also, simplify COPY commands.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2025
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Apr 4, 2025

This will be a draft until open items at metal3-io/ironic-image#666 and related to release automation are agreed.

@tuminoid tuminoid force-pushed the tuomo/add-labels-to-dockerfile branch 3 times, most recently from 857c3a4 to a4abdf7 Compare April 7, 2025 12:32
@tuminoid tuminoid marked this pull request as ready for review April 7, 2025 12:32
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@metal3-io-bot metal3-io-bot requested review from honza and kashifest April 7, 2025 12:32
@tuminoid
Copy link
Member Author

tuminoid commented Apr 7, 2025

This will be a draft until open items at metal3-io/ironic-image#666 and related to release automation are agreed.

Settled.

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
Just in case.

@tuminoid
add labels to Dockerfile
3d9e3b3 
Add org.opencontainers labels to Dockerfile.
image.version will be set by build automation.

Also, simplify go.mod COPY lines.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/add-labels-to-dockerfile branch from a4abdf7 to 3d9e3b3 Compare April 7, 2025 12:50
@tuminoid
Copy link
Member Author

tuminoid commented Apr 7, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

kashifest
kashifest reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@tuminoid
Copy link
Member Author

tuminoid commented Apr 8, 2025

/cc @lentzi90

@metal3-io-bot metal3-io-bot requested a review from lentzi90 April 8, 2025 13:10
kashifest
kashifest reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@metal3-io-bot metal3-io-bot merged commit ccc4e18 into metal3-io:main Apr 9, 2025
13 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-labels-to-dockerfile branch April 9, 2025 05:34
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

@honza honza Awaiting requested review from honza

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@tuminoid @metal3-io-bot @kashifest