Skip to content

Conversation

SD-13
Copy link
Contributor

@SD-13 SD-13 commented Jul 23, 2025

What this PR does / why we need it:
This is PR enable lint checks for FKAS and fix existing lint check failures

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2118

Signed-off-by: Sujay <sujaydey641@gmail.com>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunnatillo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2025
@metal3-io-bot
Copy link
Contributor

Hi @SD-13. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2025
@SD-13 SD-13 changed the title Enable lint checks for FKAS 🌱 Enable lint checks for FKAS Jul 23, 2025
@smoshiur1237
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2025
@peppi-lotta
Copy link
Member

FKAS is used only in the metal3-centos-e2e-feature-test-main-scalability test. That test is broken at the moment. I think scalability test should be run on this PR so I'm putting this on hold until scalability test is fixed.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@tuminoid
Copy link
Member

tuminoid commented Aug 4, 2025

I approved the workflows, let's see how the linting looks like from workflow perspective.

@tuminoid
Copy link
Member

tuminoid commented Aug 4, 2025

Linters are happy, so let's wait for the scalability test fix to see we did not break it with the linter required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golangci-lint does not lint FKAS
5 participants