Skip to content

🌱 Approvers: remove Derek, add Adam #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-28.0
Choose a base branch
from
Open

🌱 Approvers: remove Derek, add Adam #737

wants to merge 1 commit into from

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #733

/assign tuminoid

@dtantsur
Approvers: remove Derek, add Adam
e38c520 
Derek is no longer working in our team, so removing him.

Adam has contributed significant features to ironic-image, and has been
reviewing both it and IrSO consistently.

We should probably consider more promotions, but at least the gap is
covered.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot mentioned this pull request Aug 21, 2025
Merged
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Aug 21, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2025
@tuminoid
Copy link
Member

/retitle 🌱 Approvers: remove Derek, add Adam

@metal3-io-bot metal3-io-bot changed the title [release-28.0] 🌱 Approvers: remove Derek, add Adam 🌱 Approvers: remove Derek, add Adam Aug 21, 2025
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-10 metal3-ubuntu-e2e-integration-test-release-1-10

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-10, metal3-ubuntu-e2e-integration-test-release-1-10

In response to this:

/override metal3-centos-e2e-integration-test-release-1-10 metal3-ubuntu-e2e-integration-test-release-1-10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Aug 21, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @elfosardo @dtantsur

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2025
@tuminoid
Copy link
Member

/retest

3 similar comments
@kashifest
Copy link
Member

/retest

@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
ironic-image - v28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@metal3-io-bot @tuminoid @elfosardo @kashifest @dtantsur