Skip to content

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Feb 6, 2025

  • Do not run the workflow on push
  • Pin all actions used in the workflow to their hashes
  • Extract a separate run.sh for easier reuse in other jobs
  • Make sure to cd to a predictable location (again, easier reuse)
  • Consistently use /usr/bin/env in shebang
  • Update the test README with missing information

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2025
* Do not run the workflow on push
* Pin all actions used in the workflow to their hashes
* Extract a separate run.sh for easier reuse in other jobs
* Make sure to cd to a predictable location (again, easier reuse)
* Consistently use /usr/bin/env in shebang
* Update the test README with missing information

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@metal3-io-bot metal3-io-bot merged commit 92a441f into metal3-io:main Feb 7, 2025
21 checks passed
@dtantsur dtantsur deleted the irso-ci branch February 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants